Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protobufs #3276

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Update protobufs #3276

merged 6 commits into from
Oct 10, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Oct 3, 2024 •
edited
Loading

No description provided.

@mmetc mmetc added this to the 1.6.4 milestone Oct 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc marked this pull request as draft October 3, 2024 15:22
@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 19.23077% with 63 lines in your changes missing coverage. Please review.

Project coverage is 39.22%. Comparing base (4ea0537) to head (0729656).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/protobufs/notifier_grpc.pb.go 18.46% 51 Missing and 2 partials ⚠️
pkg/protobufs/notifier.pb.go 0.00% 3 Missing ⚠️
cmd/notification-dummy/main.go 0.00% 1 Missing ⚠️
cmd/notification-email/main.go 0.00% 1 Missing ⚠️
cmd/notification-file/main.go 0.00% 1 Missing ⚠️
cmd/notification-http/main.go 0.00% 1 Missing ⚠️
cmd/notification-sentinel/main.go 0.00% 1 Missing ⚠️
cmd/notification-slack/main.go 0.00% 1 Missing ⚠️
cmd/notification-splunk/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3276      +/-   ##
==========================================
+ Coverage   39.20%   39.22%   +0.01%     
==========================================
  Files         480      480              
  Lines       62061    62061              
==========================================
+ Hits        24334    24346      +12     
+ Misses      35082    35076       -6     
+ Partials     2645     2639       -6
Flag Coverage Δ
bats 31.41% <25.86%> (+0.05%) ⬆️
unit-linux 34.71% <30.00%> (+0.01%) ⬆️
unit-windows 24.66% <19.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as ready for review October 3, 2024 19:41
@mmetc mmetc marked this pull request as draft October 3, 2024 19:42
@mmetc mmetc force-pushed the update-protobufs branch 3 times, most recently from ed63fd9 to 67fc545 Compare October 4, 2024 08:06
@mmetc mmetc marked this pull request as ready for review October 4, 2024 08:31
@mmetc mmetc force-pushed the update-protobufs branch from e86c881 to ba694cc Compare October 4, 2024 12:08
@mmetc mmetc merged commit 50d115b into master Oct 10, 2024
16 of 17 checks passed
@mmetc mmetc deleted the update-protobufs branch October 10, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blotus blotus blotus approved these changes

Assignees
No one assigned
Labels
kind/dependencies needs/area
Projects
None yet
Milestone
1.6.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mmetc @blotus